Add ets:update_counter #1406
Merged
Add ets:update_counter #1406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheSobkiewicz
changed the title
TheSobkiewicz
force-pushed
the
thesobkiewicz/nifs/ets/update_counter
branch
from
0be618b to
4d64c65
Compare
bettio
requested changes
Dec 22, 2024
TheSobkiewicz
force-pushed
the
thesobkiewicz/nifs/ets/update_counter
branch
6 times, most recently
from
8b5e005 to
ce7fa79
Compare
35 tasks
TheSobkiewicz
force-pushed
the
thesobkiewicz/nifs/ets/update_counter
branch
3 times, most recently
from
ecfc907 to
4522c6b
Compare
bettio
requested changes
Feb 14, 2025
src/libAtomVM/nifs.c
Outdated
| case EtsBadEntry: | ||
| RAISE_ERROR(BADARG_ATOM); | ||
| case EtsAllocationFailure: | ||
| RAISE_ERROR(MEMORY_ATOM); |
There was a problem hiding this comment.
I think you mean OUT_OF_MEMORY_ATOM.
There was a problem hiding this comment.
Should I also refactor other ets functions? Most of them are raising MEMORY_ATOM in this place
There was a problem hiding this comment.
let's do that on a different PR.
There was a problem hiding this comment.
Maybe I will also format ets_table line to be shorter there ?
TheSobkiewicz
force-pushed
the
thesobkiewicz/nifs/ets/update_counter
branch
from
4522c6b to
c662a19
Compare
bettio
reviewed
Feb 17, 2025
TheSobkiewicz
force-pushed
the
thesobkiewicz/nifs/ets/update_counter
branch
2 times, most recently
from
f807e22 to
9ca0d2c
Compare
bettio
requested changes
Feb 17, 2025
TheSobkiewicz
force-pushed
the
thesobkiewicz/nifs/ets/update_counter
branch
from
9ca0d2c to
056e8be
Compare
Signed-off-by: Tomasz Sobkiewicz <tomasz.sobkiewicz@swmansion.com>
TheSobkiewicz
force-pushed
the
thesobkiewicz/nifs/ets/update_counter
branch
from
056e8be to
2e927e7
Compare
bettio
approved these changes
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently this solution doesn't support list of UpdateOp to update multiple counters.
Based on:
#1405
https://www.erlang.org/docs/23/man/ets#update_counter-3
These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later