Add option to insert list in ets:insert, ets:lookup refactor

[TheSobkiewicz]

Changes:

• Enabled ets:insert/2 to accept lists for bulk insertion.
• Extracted helper functions for ets:lookup/2 and ets:insert/2 that do not apply table locks.

Use Cases for the Helper Functions:

The new helper functions can be utilized in the following ETS operations to reduce code duplication:

• ets:update_element/3
• ets:insert_new/2
• ets:update_counter/3
• ets:update_counter/4
• ets:take/2
• ets:delete_object/2

Every mentioned function will be implemented after merging of this PR.

These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).

SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later

[bettio]

Still few minor changes are required, thanks for this work so far.

[bettio]

I'm sorry about this additional round of comments, hope they can be somehow interesting to you and not just boring nitpicking.
Thanks for the contribution so far ❤️.

[TheSobkiewicz]

I'm sorry about this additional round of comments, hope they can be somehow interesting to you and not just boring nitpicking. Thanks for the contribution so far ❤️.

Don't worry, thank you for your patience when reviewing it ❤️

[bettio]

I resolved open points I believe are still open. After that we are good I think. I would appreciate also a check from @jakub-gonet

[jakub-gonet]

@bettio done. Found mostly nits and one missing free.

[bettio]

There is one last thing I suggest to change, after that just git rebase main and let's merge it (after a CI run).

[bettio]

Why we don't move this block to the beginning of this function?
e.g.

struct HNode *ets_hashtable_new_node(term entry, int keypos, GlobalContext *global)
{
    struct HNode *new_node = malloc(sizeof(struct HNode));
    if (IS_NULL_PTR(new_node)) {
        return NULL;
    }

    size_t size = (size_t) memory_estimate_usage(entry);
    if (memory_init_heap(&new_node->heap, size) != MEMORY_GC_OK) {
        free(new_node);
        return NULL;
    }
   term new_entry = memory_copy_term_tree(&heap, entry);

   [...]

so we can avoid doing new_node->heap = heap that doesn't smell really good.

[TheSobkiewicz]

Good idea, we are also able to reduce the number of function arguments in this way.