Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload E2E test not working in this CI #259

Closed
joepio opened this issue Oct 28, 2022 · 1 comment
Closed

Upload E2E test not working in this CI #259

joepio opened this issue Oct 28, 2022 · 1 comment

Comments

@joepio
Copy link
Member

joepio commented Oct 28, 2022

For some reason, one specific E2E test has been failing only in the CI of atomic-data-browser.

It's the download, upload test. It works fine locally, and the rust build works fine, too.

322: waiting for selector "[data-test]:has-text("testimage.svg")"

And here the screenshots:

test-failed-4
test-failed-3
test-failed-2
test-failed-1

Seems like the first screenshot is showing a failed upload, I suspect the cookie not to be sent.

EDIT: has to do with #253. Cookie auth is not working cross origin, which is used when uploading the file.

joepio added a commit that referenced this issue Oct 28, 2022
@joepio
Copy link
Member Author

joepio commented Oct 28, 2022

Yup, turning on signed HTTP requests for uploads fixed the issue. #253 (cross-origin cookies) would fix this.

@joepio joepio closed this as completed Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant