Skip to content

Commit

Permalink
fix: Removed shell=True in pam
Browse files Browse the repository at this point in the history
  • Loading branch information
YuukanOO committed Apr 9, 2019
1 parent d547b55 commit ca25a9a
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions pytlas/pam.py
Original file line number Diff line number Diff line change
Expand Up @@ -106,8 +106,7 @@ def install_dependencies_if_needed(directory, stdout=None):

logging.info('Installing skill dependencies from "%s"' % directory)

subprocess.check_output(['pip', 'install', '-r', 'requirements.txt'],
shell=True,
subprocess.check_output(['pip', 'install', '-r', 'requirements.txt'],
stderr=subprocess.STDOUT,
cwd=directory)
elif stdout: # pragma: no cover
Expand Down Expand Up @@ -154,7 +153,7 @@ def install_skills(directory, stdout=None, *names):
if stdout: # pragma: no cover
stdout(' Cloning skill repository')

subprocess.check_output(['git', 'clone', url, dest], shell=True, stderr=subprocess.STDOUT)
subprocess.check_output(['git', 'clone', url, dest], stderr=subprocess.STDOUT)

logging.info('Successfully cloned skill "%s"' % repo)

Expand Down Expand Up @@ -211,7 +210,7 @@ def update_skills(directory, stdout=None, *names):
continue

try:
subprocess.check_output(['git', 'pull'], shell=True, cwd=folder, stderr=subprocess.STDOUT)
subprocess.check_output(['git', 'pull'], cwd=folder, stderr=subprocess.STDOUT)

install_dependencies_if_needed(folder, stdout)

Expand Down

0 comments on commit ca25a9a

Please sign in to comment.