Round up fractional cpu values for ActiveProcessorsCount #944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kubernetes supports fractional units in cpu requests and limits. When we calculate ActiveProcessorsCount, and cpu request is, say, 3.1 (which is equivalent to 3200m) we don't round it up, as a result, products fail to start because ActiveProcessorsCount expects int not float.
Changes in this PR round up fractional cpu requests:
I decided not to round up to the closest non fractional value, so if it's 3.8 it's still not 4 cores, that's why it's safer to set 3.
Also, updating upload-action version because v3 is no longer supported. Test run with new artifacts version.
Checklist
e2elabel)