Create a dedicated Synchrony ingress #883
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, synchrony path is hardcoded in the ingress which make it impossible to deploy 2 instances of Synchrony using the same hostname but different paths. For example, it's not possible to deploy the following in one cluster:
While it's possible to define Confluence
contextPath
it's not possible to do so for Synchrony. This PR makes it possible to create a dedicated ingress for Synchrony where it's possible to use rewrite path annotations. Sadly, redefining Synchrony contextPath results in Synchrony not being able to start. With this change it'll be possible to define synchony path in the ingress aspath: /synchrony1(/|$)(.*)
and addnginx.ingress.kubernetes.io/rewrite-target: /synchrony/$2
annotation. This way requests to synchrony1 will go to Synchrony service on /synchrony path.If
synchrony.ingress.path
is defined, we'll update system property passed to Confluence JVM accordingly.Checklist
e2e
label)