BAM-25528: Unset pre-stop hook for bamboo-agent #719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nanux
approved these changes
Nov 20, 2023
|
@nanux a failed pre-stop hook can only be discovered through k8s events, and only when you terminate the pod. Is benign in nature. If a preStop hook fails, kubelet just kills the container. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The shutdown script isn't part of the agent image, so this pre-stop hook was always failing. In fact, a proper pre stop hook for an agent will be the one that checks if an agent is busy or not. However, there's no such feature.
This PR sets
agent.shutdown.commandto nil but still makes it possible to have a pre-stop hook if the command is defined in user provided values.