Avoid using np.maximum_sctype (dropped in NumPy 2)

[neutrinoceros]

Fixes #818, but doesn't yet allow testing against numpy 2: astroscrappy needs a compatible release before that.

[neutrinoceros]

I've opened astropy/astroscrappy#84 too

[neutrinoceros]

failures seem unrelated but real. @mwcraig let me know if you'd like my help with these too.

[mwcraig]

failures seem unrelated but real. @mwcraig let me know if you'd like my help with these too.

@neutrinoceros that would be awesome -- I'll have time in the next few days if you don't get to it.

[neutrinoceros]

@mwcraig I opened #820 and #821 to fix everything. In principle this one can be merged independently but I'm happy to rebase once those two get in if you'd like.

[mwcraig]

@neutrinoceros -- could you please rebase just to make sure everything is green?

[neutrinoceros]

Actually I'm afk for today but I think I might be able to restart CI fresh with a close+reopen

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.55%. Comparing base (649330c) to head (d09866f).
Report is 8 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #819   +/-   ##
=======================================
  Coverage   97.55%   97.55%           
=======================================
  Files           9        9           
  Lines        1392     1392           
=======================================
  Hits         1358     1358           
  Misses         34       34           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mwcraig]

Thanks, merged it!