Fix issue 3187: Missing unit strings in UNIT_MAPPER for ipac.nexsci.nasa_exoplanet_archive #3188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3188 +/- ##
=======================================
Coverage 67.62% 67.62%
=======================================
Files 229 229
Lines 18594 18594
=======================================
Hits 12574 12574
Misses 6020 6020 ☔ View full report in Codecov by Sentry. |
bsipocz
approved these changes
Jan 23, 2025
bsipocz
force-pushed
the
fix_issue_3187
branch
from
ae1d886 to
24bcb2d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added units
'microns','micron','hour', and'uas'to theUNIT_MAPPERdict to get rid of warning thrown for unrecognized units.fixes #3187