fix sciserver downloads in heasarc (#3182) #3183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsipocz
approved these changes
Jan 16, 2025
CHANGES.rst
Outdated
| @@ -13,6 +13,18 @@ Infrastructure, Utility and Other Changes and Additions | |||
| ------------------------------------------------------- | |||
|
|
|||
|
|
|||
| 0.4.9 (TBD) | |||
| @@ -692,16 +692,17 @@ def _copy_sciserver(self, links, location='.'): | |||
| Users should be using `~self.download_data` instead | |||
|
|
|||
| """ | |||
| if not (os.path.exists('/FTP/') and os.environ['HOME'].split('/')[-1] == 'idies'): | |||
| if not os.path.exists('/FTP/'): | |||
There was a problem hiding this comment.
Not relevant to this PR, but slowly we should move along to use pathlib
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3183 +/- ##
==========================================
+ Coverage 67.57% 67.62% +0.04%
==========================================
Files 229 229
Lines 18593 18594 +1
==========================================
+ Hits 12565 12574 +9
+ Misses 6028 6020 -8 ☔ View full report in Codecov by Sentry. |
|
I've rebased this to get rid of the conflict and now will merge once CI is all green. Thanks @zoghbi-a! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #3182
This ensures the folder is create if it does not exist. Downloading a
foo/barfolder now copies the data todownload_location/barinstead ofdownload_location.A unit test is added for cases of downloaded folders and files.
closes #3182