Handle non-ICRS coordinates in query functions

[snbianco]

This PR handles coordinates passed into query functions that are not in the ICRS frame. If it is found that the given coordinates are not in ICRS, they are transformed.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.70%. Comparing base (311197b) to head (76610a1).
Report is 19 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #3164   +/-   ##
=======================================
  Coverage   68.69%   68.70%           
=======================================
  Files         231      231           
  Lines       19214    19220    +6     
=======================================
+ Hits        13199    13205    +6     
  Misses       6015     6015           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[bsipocz]

I wonder if this should live in the commons function, or you could use what we already have for simbad (_parse_coordinate_and_convert_to_icrs)?
(or also move the simbad one to commons? cc @ManonMarchand )

_parse_coordinate_and_convert_to_icrs

[bsipocz]

I wonder if this should be a kwarg argument for commons.parse_coordinates instead? e.g. to convert right at the end before returning the current output

[snbianco]

Do you mean a parameter like return_frame or something to that effect that you could pass in a value like 'ICRS' and get the coordinate back in whatever frame was given?

[snbianco]

Just made this change! I added a return_frame parameter to utils.commons.parse_coordinates that defaults to None. If it is provided and the coordinates are not already in that frame, it will attempt to transform them. If the transformation fails, a warning is issued and the coordinates are returned as is, without the transformation.

[ManonMarchand]

Oh that methods only parses coordinates if I detect that they are written as a sim-script string. This is an old way of writing coordinates that only existed in the former Simbad interface (hence this is in Simbad's utils and not in commons).
In the other cases I use parse_coordinates from commons and then convert the SkyCoord it returns to icrs 🙂