-
-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Download Products with MastMissions #3155
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3155 +/- ##
==========================================
+ Coverage 67.57% 67.75% +0.17%
==========================================
Files 229 229
Lines 18593 18733 +140
==========================================
+ Hits 12565 12692 +127
- Misses 6028 6041 +13 ☔ View full report in Codecov by Sentry. |
Tagging @astrojimig and @dr-rodriguez for visibility |
Pinging this MR again just in case it got lost in the shuffle of the holidays and/or AAS. |
ac7f334
to
aab812a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Overall this looks good.
I noticed there are a couple of test failures and errors, but all of the look unrelated to this PR, so I go ahead with the merge now. If you could look into them and open a PR with a fix, it would be great.
# Return filtered products | ||
return products[filter_mask] | ||
|
||
def download_file(self, uri, *, local_path=None, cache=True, verbose=True): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we'll need to unify all these download fuctionalities between the different modules. So it's more like a heads up, that something will come in place as a utility either in astroquery or in pyvo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the heads up! I put the test fixes into #3164.
Thanks! |
Was this supposed to be in the newest release? The release was made after this was merged, but it doesn't seem like this merge is in the included commits. |
It should be in it but I may have messed up the cherry picking. (It was a one off quick release to fix some regression, so not everything got included) |
Download Products with MastMissions
I ended up doing a 0.4.9.post1 release as I used the same errenous cherry-pick command for multiple PRs. A normal |
This MR adds methods to
MastMissions
that allow users to retrieve and download products from the Missions-MAST API.get_product_list
get_unique_product_list
filter_products
download_products
download_file
A few notes:
mission
property so that users can use the sameMastMissions
object to query multiple missions.dataset_kwds
and_default_ullyses_cols
, for example). These are due to limitations in the API, and I've reported these problems internally at MAST.missions_request_async
function toservices.py
to handle API requests coming fromMastMissions
.