Restore get_query_payload to all methods #2532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2532 +/- ##
==========================================
+ Coverage 63.06% 63.07% +0.01%
==========================================
Files 133 133
Lines 17322 17333 +11
==========================================
+ Hits 10924 10933 +9
- Misses 6398 6400 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
bsipocz
approved these changes
Sep 17, 2022
| @@ -520,7 +520,7 @@ class = 'galaxy' \ | |||
|
|
|||
| def get_spectra_async(self, coordinates=None, radius=2. * u.arcsec, | |||
| matches=None, plate=None, fiberID=None, mjd=None, | |||
| timeout=TIMEOUT, | |||
| timeout=TIMEOUT, get_query_payload=False, | |||
There was a problem hiding this comment.
the order of the kwargs are different than in the previous release (before the previous PR). So while it's not strictly related, making all optional arguments keyword only is the way to go here.
| @@ -640,8 +650,8 @@ def get_spectra_async(self, coordinates=None, radius=2. * u.arcsec, | |||
| @prepend_docstr_nosections(get_spectra_async.__doc__) | |||
| def get_spectra(self, coordinates=None, radius=2. * u.arcsec, | |||
| matches=None, plate=None, fiberID=None, mjd=None, | |||
| timeout=TIMEOUT, cache=True, | |||
| data_release=conf.default_release, | |||
| timeout=TIMEOUT, get_query_payload=False, | |||
There was a problem hiding this comment.
same, make these keyword only, otherwise this is a backward incompatible API change
|
Thank you @weaverba137! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #2516.
Specifically the methods
get_images(_async)andget_spectra(_async)haveget_query_payloadrestored.All other methods already fully support
get_query_payloadexceptget_spectral_template(_async), which never supported it, as far as I can tell. That method works significantly differently from all other methods, so it is not surprising that it does not have that capability.Unit tests are included to verify that the query payload really is returned by these updated methods.