Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed URL for RR Lyrae dataset download #42

Merged
merged 1 commit into from
May 19, 2023

Conversation

jeanlucmargot
Copy link
Contributor

Fixed and tested.

@bsipocz
Copy link
Member

bsipocz commented May 8, 2023

There is a redirect in place for the master-->main renames. Do you run into any issues with it.

Also, we have just recently moved the main functionality upstream, Given the recent move of the main functionality upstream, also the potential plans of moving the remaining ones and archiving the repo we may not fixing this?

(I suppose, we could also move the datasets functions upstream to astroML proper?)

@jeanlucmargot
Copy link
Contributor Author

Thank you. A senior astrophysics undergraduate student was unable to install/run the software. I reproduced the problem independently. Install works with the fix, it does not without the fix.

@bsipocz
Copy link
Member

bsipocz commented May 9, 2023

Hmm, I see. Have your student tried to install the released version from pypi, or what is currently on the master branch? I, too, run into a HTTPError when 0.3 is installed, as it tries to fetch the data from the mpia link, but when I install the dev version with e.g. pip install git+https://github.com/astroML/gatspy, it all seems to work.

@jeanlucmargot
Copy link
Contributor Author

My student indicates that he installed with pip and still had the issue.

@bsipocz
Copy link
Member

bsipocz commented May 19, 2023

I still don't think this would make a difference, but OK with merging this PR. Eventually, I'll move these data-fetching functions upstream to astroML (#38 (comment)) as part of the retirement of this package.

@bsipocz bsipocz merged commit 71384b8 into astroML:master May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants