Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Trusted Auctioneer: Code cleanups #24

Open
wants to merge 6 commits into
base: bharath/api-to-query-optimistic-block
Choose a base branch
from
Open

feat: Trusted Auctioneer: Code cleanups #24

wants to merge 6 commits into from

Conversation

bharath-123
Copy link
Collaborator

@bharath-123 bharath-123 commented Dec 6, 2024 •
edited
Loading

The PR involves the following changes:

  1. improves logging
  2. Adds a helper WrapError which wraps errors with a message string cleanly
  3. Make NextFeeRecipient an atomic pointer
  4. Remove reserved addresses from both queued and pending queues. Previously we were only removing reserved addressses from pending only.

@bharath-123 bharath-123 marked this pull request as ready for review January 3, 2025 11:12
@bharath-123 bharath-123 changed the title Code cleanups feat: Trusted Auctioneer: Code cleanups Jan 3, 2025
@bharath-123 bharath-123 force-pushed the bharath/api-to-query-optimistic-block branch from bd22223 to fcf03af Compare January 9, 2025 09:59
@bharath-123 bharath-123 force-pushed the bharath/code-cleanups branch from 3c9c875 to 0b92dde Compare January 9, 2025 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joroshiba joroshiba Awaiting requested review from joroshiba joroshiba is a code owner

@mycodecrafting mycodecrafting Awaiting requested review from mycodecrafting mycodecrafting is a code owner

@noot noot Awaiting requested review from noot noot is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bharath-123