tests(sequencer): add unit tests for bridge_account_last_tx_hash and transaction_fee ABCI queries
#1998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
add unit tests for
bridge_account_last_tx_hashandtransaction_feeABCI queriesBackground
unit tests were missing for these functions.
Changes
bridge_account_last_tx_hashandtransaction_feeABCI queriestransaction_feequery does not error if one of thefee_assetsis not an authorized fee asset in state. is this something we want to check? is there a case where someone may want to calculate the fee for an action but not use a currently authorizedfee_asset?Testing
no code changes, just tests added.
Related Issues
closes #1741