[red-knot] Add a regression test for recent improvement to TypeInferenceBuilder::infer_name_load()
#16310
+39
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexWaygood
added
testing
AlexWaygood
requested review from
carljm,
MichaReiser and
sharkdp
as code owners
|
It was wonderful how easy it was to write this test. Thanks so much @sharkdp for adding the custom-typeshed feature to mdtest! |
…enceBuilder::infer_name_load()`
AlexWaygood
force-pushed
the
alex/moduletype-fallback-test
branch
from
97531a6 to
23af637
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a regression test for the subtle bug fixed in #16284
Test Plan
I verified that this test fails if you check out c2b9fa8 and add the test.