-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[flake8-builtins
] Remove builtins-
prefix from option names
#16092
base: main
Are you sure you want to change the base?
Conversation
|
0eb38e6
to
c163482
Compare
Thanks. I think the What we did in the past is to emit a deprecation warning for renamed settings so that we can remove the old names at some point in the future. It probably requires duplicating the fields on the |
As an additional reference, I think the infrastructure already exists and |
5e78095
to
56895d5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
ff9406a
to
f9e1f0f
Compare
Summary
Resolves #15368.
The following options have been renamed:
builtins-allowed-modules
→allowed-modules
builtins-ignorelist
→ignorelist
builtins-strict-checking
→strict-checking
To preserve compatibility, the old names are kept as Serde aliases.
Test Plan
cargo nextest run
andcargo insta test
.