Implement B903 and B907 flake8-bugbear rules #13600
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes astral-sh#3758 Implement B903 and B907 flake8-bugbear rules in Ruff. * Add `crates/ruff_linter/src/rules/flake8_bugbear/rules/b903.rs` to implement B903 rule for data classes that only set attributes in an `__init__` method. * Add `crates/ruff_linter/src/rules/flake8_bugbear/rules/b907.rs` to implement B907 rule to replace f"'{foo}'" with f"{foo!r}". * Update `crates/ruff_linter/src/rules/flake8_bugbear/mod.rs` to include B903 and B907 rules. * Add test cases for B903 and B907 rules in `crates/ruff_linter/src/rules/flake8_bugbear/tests.rs`.
* **New Rules** - Add `UseDataclassesForDataClasses` variant to `Rule` enum - Add `FStringSingleQuotes` variant to `Rule` enum
* **Update `Rule` enum** - Add `UseDataclassesForDataClasses` for B903 - Add `FStringSingleQuotes` for B907 * **Update imports in `mod.rs`** - Add `use_dataclasses_for_data_classes::*` - Add `f_string_single_quotes::*`
|
FYI, there's another implementation of |
|
Thanks @dhruvmanila. I'll remove the B903 implementation and instead create a PR for B907 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3758
Implement B903 and B907 flake8-bugbear rules in Ruff.
crates/ruff_linter/src/rules/flake8_bugbear/rules/b903.rsto implement B903 rule for data classes that only set attributes in an__init__method.crates/ruff_linter/src/rules/flake8_bugbear/rules/b907.rsto implement B907 rule to replace f"'{foo}'" with f"{foo!r}".crates/ruff_linter/src/rules/flake8_bugbear/mod.rsto include B903 and B907 rules.crates/ruff_linter/src/rules/flake8_bugbear/tests.rs.