Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[red-knot] don't include Unknown in the type for a conditionally-defined import #13563

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

[red-knot] don't include Unknown in the type for a conditionally-defined import #13563

wants to merge 2 commits into from
+121 −51

Commits on Oct 2, 2024

  1. use Never type instead of Unknown for unbound public types 

    Uses `Type::Never` instead of `Type::Unknown` for the case where
a publicly available variable is unbound. In the case where it is
unbound, we want a union of its actual type with `Never` instead of
`Unbound`, because the `Unbound` case will cause runtime error.
    @pilleye
    pilleye committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    8a3a0d8 View commit details
    Browse the repository at this point in the history

  2. Add context for symbol_ty lookup

    @pilleye
    pilleye committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    b19c32f View commit details
    Browse the repository at this point in the history