Backends: fix corner case error in public key retrieval #1068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When connection to the database is sometimes unstable, it was possible that failure to retrieve the public key made users unable to use Pairing API - as Pairing crashed while checking authorization. This seemed to be a problem with CQEx. Replace it with the Xandra driver. Signed-off-by: Arnaldo Cesco <arnaldo.cesco@secomind.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-1.2 #1068 +/- ##
===============================================
- Coverage 68.43% 68.38% -0.06%
===============================================
Files 282 282
Lines 7448 7483 +35
===============================================
+ Hits 5097 5117 +20
- Misses 2351 2366 +15 ☔ View full report in Codecov by Sentry. |
Same as previous commit, but in Realm Management. Signed-off-by: Arnaldo Cesco <arnaldo.cesco@secomind.com>
Same as the two previous commit, but in AppEngine. Signed-off-by: Arnaldo Cesco <arnaldo.cesco@secomind.com>
Annopaolo
force-pushed
the
reliable-public-key-retrieval
branch
from
bf1feed to
7386077
Compare
Annopaolo
added
database
matt-mazzucato
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
When connection to the database is sometimes unstable, it was possible that failure to retrieve the public key made
users unable to use APIs - as backend services crashed while checking authorization.
This seemed to be a problem with CQEx, so replace it with the Xandra driver.
This change applies to AppEngine, Realm Management and Pairing.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g. usage docs, diagrams, etc.: