refactor(appengine): port auth, health, rooms and stats to exandra #1064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this allows calling `mix format` in dev Signed-off-by: Francesco Noacco <francesco.noacco@secomind.com>
The first installment in the effort of refactoring the device module. The change can be made little by little as exandra and cqex queries can coexist. This change ports a few queries to exandra, without making any big logic refactor, but we can see the future direction of this refactor: Astarte.AppEngine.API.Device.Queries becomes a module to expose _queries_ and not data from the database directly. For this iteration, this is enough to elegantly use the queries in the Device module, but more complex queries may require a more in-depth refactor. The following queries have been ported: - `retrieve_interfaces_list` - `retrieve_all_endpoints_for_interface!` - `retrieve_mapping` - `prepare_value_type_query` / `execute_value_type_query` Signed-off-by: Francesco Noacco <francesco.noacco@secomind.com>
this function needs some special attention because by default Ecto SQL raises if we get an error back from exandra. as this function is also supposed to handle the situation where the keyspace does not exist, which results in a Xandra.Error being generated, we need to use a _workaround_ which lets us handle the error ourselves. Signed-off-by: Francesco Noacco <francesco.noacco@secomind.com>
we take a similar approach to `fetch_public_key` to be able to handle errors from exandra. Signed-off-by: Francesco Noacco <francesco.noacco@secomind.com>
remove the query as it's a simple device fetch Signed-off-by: Francesco Noacco <francesco.noacco@secomind.com>
this change makes it so that if a database exception is raised by ecto, phoenix handles the error by showing custom details. Signed-off-by: Francesco Noacco <francesco.noacco@secomind.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1064 +/- ##
==========================================
+ Coverage 69.23% 70.02% +0.79%
==========================================
Files 275 252 -23
Lines 7193 5612 -1581
==========================================
- Hits 4980 3930 -1050
+ Misses 2213 1682 -531 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change focuses solely on porting the queries from the modules above to exandra.
Depends on #1055