refactor(appengine): exandra queries for device #1055
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1055 +/- ##
==========================================
+ Coverage 69.23% 71.93% +2.70%
==========================================
Files 275 235 -40
Lines 7193 5277 -1916
==========================================
- Hits 4980 3796 -1184
+ Misses 2213 1481 -732 ☔ View full report in Codecov by Sentry. |
noaccOS
force-pushed
the
push-wqoykyzyqkko
branch
3 times, most recently
from
b219689 to
c3a11ea
Compare
| @@ -1,4 +1,4 @@ | |||
| [ | |||
| import_deps: [:phoenix, :ecto, :skogsra, :stream_data], | |||
| import_deps: [:phoenix, :ecto, :skogsra], | |||
There was a problem hiding this comment.
Why not keeping the :stream_data formatter? See the changes in apps/astarte_appengine_api/test/astarte_appengine_api_web/controllers/groups_controller_test.exs and apps/astarte_appengine_api/test/astarte_appengine_api_web/plug/group_name_decoder_test.exs
There was a problem hiding this comment.
I was getting an error running mix format and I missed that it was messing with the formatting of some test files.
I've added stream_data back to the formatter deps while also making it available in dev so that mix format does work correctly
this allows calling `mix format` in dev Signed-off-by: Francesco Noacco <francesco.noacco@secomind.com>
noaccOS
force-pushed
the
push-wqoykyzyqkko
branch
4 times, most recently
from
77b2303 to
12e0234
Compare
The first installment in the effort of refactoring the device module. The change can be made little by little as exandra and cqex queries can coexist. This change ports a few queries to exandra, without making any big logic refactor, but we can see the future direction of this refactor: Astarte.AppEngine.API.Device.Queries becomes a module to expose _queries_ and not data from the database directly. For this iteration, this is enough to elegantly use the queries in the Device module, but more complex queries may require a more in-depth refactor. The following queries have been ported: - `retrieve_interfaces_list` - `retrieve_all_endpoints_for_interface!` - `retrieve_mapping` - `prepare_value_type_query` / `execute_value_type_query` Signed-off-by: Francesco Noacco <francesco.noacco@secomind.com>
noaccOS
force-pushed
the
push-wqoykyzyqkko
branch
from
12e0234 to
cd6ceb3
Compare
The first installment in the effort of refactoring the device module.
The change can be made little by little as exandra and cqex queries can coexist.
This change ports a few queries to exandra, without making any big logic refactor, but we can see the future direction of this refactor: Astarte.AppEngine.API.Device.Queries becomes a module to expose queries and not data from the database directly.
For this iteration, this is enough to elegantly use the queries in the Device module, but more complex queries may require a more in-depth refactor.
The following queries have been ported:
retrieve_interfaces_listretrieve_all_endpoints_for_interface!retrieve_mappingprepare_value_type_query/execute_value_type_queryWhat this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g. usage docs, diagrams, etc.: