Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No error handling on empty search results from retriever #1275

Open
vikram-wald opened this issue Mar 18, 2025 · 1 comment
Open

No error handling on empty search results from retriever #1275

vikram-wald opened this issue Mar 18, 2025 · 1 comment

Comments

@vikram-wald
Copy link

Describe the bug
When the search api returns empty results, it is being passed to llm directly to generate report. And in absence of no context, the llm is responding that it cannot generate report. Since we are directly streaming the content to the websocket client, which might be directly used in ui, this response seems irrelevant.

Expected behavior
I think if the retriever is giving no search results, this should have been logged as error and then generate empty report.

Screenshots
Image

@ElishaKay
Copy link
Collaborator

Sup @vikram-wald

It's a fair point - we'll need to meditate on it.
What if the message says something like: "I couldn't find context related to your query - please try another search or contact your web admin if you believe this is an error. Sincerely, your AI Research Agent"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants