Parse Dimensions Function Appears to Be Incorrect

[sebastiancyndx]

Describe the bug
The parse_dimension function does not handle '%' and converts to int instead of float.

def parse_dimension(value: str) -> int:
    """Parse dimension value, handling px units"""
    if value.lower().endswith('px'):
        value = value[:-2]  # Remove 'px' suffix
    try:
        return int(value)  # Convert to float first to handle decimal values
    except ValueError as e:
        print(f"Error parsing dimension value {value}: {e}")
        return None

It should be like this:

def parse_dimension(value: str) -> float:
    """Parse dimension value, handling px units, percentages, and decimals."""
    value = value.strip().lower()
    
    if value.endswith('px'):
        value = value[:-2]  # Remove 'px' suffix
    elif value.endswith('%'):
        value = value[:-1]  # Remove '%' suffix
    
    try:
        return float(value)  # Convert to float to handle decimals
    except ValueError as e:
        print(f"Error parsing dimension value '{value}': {e}")
        return None

To Reproduce
Steps to reproduce the behavior:

1. Go to

   gpt-researcher/gpt_researcher/scraper/utils.py

   Line 50 in 8cbc3d5

   def parse_dimension(value: str) -> int:

Expected behavior
Not fail on dimensions that have a '%' or a decimal

Screenshots

Additional context
Add any other context about the problem here.

[mendeel]

Tried your solution and it fixed for me. Thanks!

[ElishaKay]

Welcome @sebastiancyndx and @mendeel & thanks for the fix

Green light for the PR for whoever would like to carve their name into the git tree