Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gpmol dependency #1

Open
DavidWalz opened this issue May 28, 2019 · 22 comments
Open

gpmol dependency #1

DavidWalz opened this issue May 28, 2019 · 22 comments

Comments

@DavidWalz
Copy link

@beangoben
First of all, thanks for providing model and data in form of a well formatted notebook. It's exciting to see that this good practice is spreading more and more across different fields!

However, I'm currently missing the gpmol dependency, which seems to contain the most integral parts of the analysis. Is it a group-internal python package? If so, would you consider open sourcing it or removing this dependency? With gpmol missing the analysis is neither reproducible, nor is gpHSP open-source as claimed in the paper.

@beangoben
Copy link
Contributor

Hi @DavidWalz,
We wrapping work on gpmol and should have open-sourced soon (end of June), the delay has been mostly life-stuff...we definitely want it to be shared, improved and reproduced.

@DavidWalz
Copy link
Author

Great!
Looking at the paper, it does shed a bad light on the reviewers who apparently didn't even bother checking out the code.
I do appreciate your effort , and am looking to testing out your model.

@gbrault
Copy link

gbrault commented Jun 27, 2019

Thanks for releasing this work open source, and of course waiting for the gpmol dependency!

@beangoben
Copy link
Contributor

definitely, will have a usable dependency in 1 week approx, along with an improved model (multioutput gp, deep gp).
Thanks for the patience.

@napoleon9000
Copy link

@beangoben Thanks for sharing all the data. Just wondering if you still have the plan to share the gpHSP source code?

@rodrija
Copy link

rodrija commented Feb 11, 2020

Please inform when the gpmol code would be released. It is unfortunate that nothing has happened since June last year.
I found your paper very useful and would like to test your code for solvent screening.

@ignaczgerg
Copy link

Hey! Is there any news regarding to make gpmol open source?

@beangoben
Copy link
Contributor

beangoben commented Feb 13, 2020 via email

@ignaczgerg
Copy link

Many thanks! We are really looking forward to it :)

@sptiwari
Copy link

Any news about the gpmol?

@sptiwari
Copy link

Hi beangoben, We are really looking forward to run the gpHSP. Could you please upload whatever you have about the gpmol. It need not be perfect. We will be more than happy with just a running version of gpHSP.

Thanks a lot.

@ignaczgerg
Copy link

Hi! Is there any news regarding the release of gpmol? Thanks.

@xuzhang5788
Copy link

@beangoben
When will you release gpmol?

@thava
Copy link

thava commented May 15, 2020

@beangoben Any insights into usage of gpmol or alternatives would be highly appreciated.

@sptiwari
Copy link

@beangoben Any update? We have been waiting for so long!

@hududed
Copy link

hududed commented Sep 10, 2020

This is frustrating when we can't follow-up on a publication due to technicality - I didn't know academia is not fond of sharing knowledge. Could it be that gpmol is being withheld for IP reasons ?

@madi20210904
Copy link

Is there any news regarding the release of gpmol? Thanks.

@jmohin
Copy link

jmohin commented Jan 16, 2023

Still waiting on release of GPmol -- coming up on 4 years now. Would love to reproduce these results and do some extensions. Some other group's papers are claiming it as a dependency, which seems to indicate to me this library is shareable.

@beangoben
Copy link
Contributor

beangoben commented Jan 16, 2023

Hi, the most recent edits (march '22) (notebooks 0 to 3) and gphsp.py cover all code required to generate features/train models and predict without requiring gpmol.

The closest thing to gpmol is https://github.com/aspuru-guzik-group/dionysus/.

@jmohin
Copy link

jmohin commented Jan 17, 2023

Thanks! I'll play with the notebooks.

@jmohin
Copy link

jmohin commented Jan 17, 2023

The notebooks fail to import gpHSP due to a dependency on gpFlow within the gphsp.py file:
ModuleNotFoundError: No module named 'gpflow'

@jmohin
Copy link

jmohin commented Jan 18, 2023

nevermind- was able to satisfy that dependency

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests