You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When commits include submodules, the respective dependencies cannot be resolved. The submodule commit OID contains the hash of the submodule commit. This commit is not present in the instance of the parent repo.
At the following place in the tree_lookup, this will lead to a KeyError being thrown:
A simple fix would be to check first whether the OID is contained in the repo and simply return None if it's not, something like this: fuulish@1c55add
This ignores submodule dependencies. However, submodule-related changes are linearly dependent on their respective parent changes. Hence, a proper solution should include the actual dependency chain. One suggestion could be like the following: fuulish@2fd1455
Let me know what you think.
The text was updated successfully, but these errors were encountered:
When commits include submodules, the respective dependencies cannot be resolved. The submodule commit OID contains the hash of the submodule commit. This commit is not present in the instance of the parent repo.
At the following place in the
tree_lookup
, this will lead to aKeyError
being thrown:git-deps/git_deps/detector.py
Line 344 in 5dd7f4c
A simple fix would be to check first whether the OID is contained in the repo and simply
return None
if it's not, something like this: fuulish@1c55addThis ignores submodule dependencies. However, submodule-related changes are linearly dependent on their respective parent changes. Hence, a proper solution should include the actual dependency chain. One suggestion could be like the following: fuulish@2fd1455
Let me know what you think.
The text was updated successfully, but these errors were encountered: