Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide Variables values via workflow file and @action/core package to src/action.js #6

Open
ashuvssut opened this issue Jul 21, 2021 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@ashuvssut
Copy link
Owner

ashuvssut commented Jul 21, 2021

For now, this Action can't be used by other people. To use this action to generate their own PDF, they need to fork this repo, edit four variables present in src/action.js.

Those four variables are:

  • OWNER
  • REPO
  • BRANCH
  • PDF_PATH

after doing this, they have created their own action that only works for their repo.


SOLUTION TO AVOID THIS OVERHEAD and make this Action reusable by everyone:
we can modify action.js any action.yml to fetch the values to feed in these variables
form the workflow file, and from the @action/core package's functions

  • use @action/core for OWNER and REPO variables
  • we can use workflow env variables for BRANCH and PDF_PATH variables

If you want to contribute, I will be there to help you out if you get stuck :) Happy Learning!

@ashuvssut ashuvssut changed the title Provide Variables values from workflow to the action Provide Variables values via workflow file and @action/core package to src/action.js Jul 21, 2021
@ashuvssut ashuvssut changed the title Provide Variables values via workflow file and @action/core package to src/action.js Provide Variables values via workflow file and @action/core package to src/action.js Jul 21, 2021
@ashuvssut ashuvssut added enhancement New feature or request good first issue Good for newcomers labels Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant