fix: latest version returns latest version #1996
Merged
+50
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrecloutier
force-pushed
the
fix_latest_version_parsing
branch
from
5e95bbd to
46d3f42
Compare
Stratus3D
reviewed
Mar 3, 2025
| @@ -359,10 +362,11 @@ func filterByExactMatch(allVersions []string, pattern string) (versions []string | |||
| return versions | |||
| } | |||
|
|
|||
| func filterOutByRegex(allVersions []string, pattern string) (versions []string) { | |||
| func filterOutByRegex(allVersions []string, pattern string, keepMatch bool) (versions []string) { | |||
There was a problem hiding this comment.
Given that this function now accepts a keepMatch bool maybe we should rename this function to filterByRegex?
Stratus3D
reviewed
Mar 3, 2025
| plugin := plugins.New(conf, pluginName) | ||
| version, err := Latest(plugin, "") | ||
| assert.Nil(t, err) | ||
| assert.Equal(t, tt.expectedOutput, version) |
There was a problem hiding this comment.
Thank you for adding tests for this ❤️
Stratus3D
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adjusting the filter to align with what the bash version of the application does here: https://github.com/andrecloutier/asdf/blob/d7e0740461a26bd3d437c2bfb02619d7e20d2489/lib/functions/versions.bash#L159
Effectively this code misses
grep -E "^\\s*[0-9]"when filtering the results fromlist-all.Fixes: #1904
Fixes: #1875
Other Information