Merge pull request #1877 from RickBarretto/deprecate-stack-discard-issue-1870

[Core\unstack] Deprecate `unstack.discard`

Author: drkameleon

src/library/Core.nim

@@ -1437,9 +1437,7 @@ proc defineModule*(moduleName: string) =
         args        = {
             "number"    : {Integer}
         },
-        attrs       = {
-            "discard"   : ({Logical},"do not return anything")
-        },
+        attrs       = NoAttrs,
         returns     = {Any},
         example     = """
             1 2 3
@@ -1448,30 +1446,23 @@ proc defineModule*(moduleName: string) =
             1 2 3
             b: unstack 2        ; b: [3 2]
             ..........
+            ; You can also discard the values using `discard`
             1 2 3
-            unstack.discard 1   ; popped 3 from the stack
+            discard unstack 1   ; popped 3 from the stack
         """:
             #=======================================================
-            if Stack[0..SP-1].len < x.i: Error_StackUnderflow()
-            
-            let doDiscard = (hadAttr("discard"))
+            if Stack[0..SP-1].len < x.i: 
+                Error_StackUnderflow()
 
             if x.i==1:
-                if doDiscard: discard stack.pop()
-                else: discard
+                discard
             else:
-                if doDiscard: 
-                    var i = 0
-                    while i<x.i:
-                        discard stack.pop()
-                        i+=1
-                else:
-                    var res: ValueArray
-                    var i = 0
-                    while i<x.i:
-                        res.add stack.pop()
-                        i+=1
-                    push(newBlock(res))
+                var res: ValueArray
+                var i = 0
+                while i<x.i:
+                    res.add stack.pop()
+                    i+=1
+                push(newBlock(res))
 
     builtin "until",
         alias       = unaliased, 

src/scripts/console.art

@@ -176,7 +176,7 @@ lookup: function [what :string :literal :regex :type][
     ]
 
     PrintFList results "found"
-    unstack.discard size stack
+    discard unstack size stack
 ]
 
 Repl: #[autocomplete?: true, hints?: true, verbose?: true]