Marked the purchasable as nullable in the model

artkonekt · Jan 13, 2025 · d5c2645 · d5c2645
1 parent 64dc6d0
commit d5c2645
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 3 deletions.
diff --git a/src/Models/CustomerPurchase.php b/src/Models/CustomerPurchase.php
@@ -16,10 +16,10 @@
  * @property Carbon $purchase_date
  * @property float $purchase_value
  * @property string $currency
- * @property int $purchasable_id
- * @property string $purchasable_type
+ * @property int|null $purchasable_id
+ * @property string|null $purchasable_type
  *
- * @property-read Model $purchasable
+ * @property-read Model|null $purchasable
  * @property-read Customer $customer
  */
 class CustomerPurchase extends Model implements CustomerPurchaseContract

diff --git a/tests/CustomerPurchaseTest.php b/tests/CustomerPurchaseTest.php
@@ -14,6 +14,20 @@ class CustomerPurchaseTest extends TestCase
      * @test
      */
     public function customer_purchase_can_be_created_with_minimal_data(): void
+    {
+        $customer = CustomerProxy::create([])->fresh();
+
+        $customerPurchase = CustomerPurchaseProxy::create([
+            'customer_id' => $customer->id,
+        ])->fresh();
+
+        $this->assertTrue($customer->is($customerPurchase->customer));
+    }
+
+    /**
+     * @test
+     */
+    public function customer_purchase_can_be_created_with_a_customer_and_a_purchasable(): void
     {
         $order = Order::create([
             'number' => '70H-0WJB-2OD6'