Skip to content

Commit

Permalink
Laravel 11.15+ and SQLite compatibility fix
Browse files Browse the repository at this point in the history
- Added PHP 8.4 to the CI
- Bump Laravel to v11.35 in the CI
  • Loading branch information
fulopattila122 committed Dec 14, 2024
1 parent ba753e5 commit 18b94d3
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 5 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,13 @@ jobs:
timeout-minutes: 10
strategy:
matrix:
php: ['8.1', '8.2', '8.3']
laravel: ['10.0', '10.48', '11.0', '11.5']
php: ['8.1', '8.2', '8.3', '8.4']
laravel: ['10.0', '10.48', '11.0', '11.35']
exclude:
- php: '8.1'
laravel: '11.0'
- php: '8.1'
laravel: '11.5'
laravel: '11.35'
name: PHP ${{ matrix.php }} Laravel ${{ matrix.laravel }}
steps:
- name: Checkout
Expand Down
6 changes: 6 additions & 0 deletions Changelog.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# Customer Module Changelog

## Unreleased
##### 2024-XX-YY

- Fixed an SQLite migration error with Laravel 11.15+
- Added PHP 8.4 support

## 3.1.0
##### 2024-11-25

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,10 @@ public function up(): void
$table->intOrBigIntBasedOnRelated('default_billing_address_id', Schema::connection(null), 'addresses.id')->nullable();
$table->intOrBigIntBasedOnRelated('default_shipping_address_id', Schema::connection(null), 'addresses.id')->nullable();

$table->foreign('default_billing_address_id')->references('id')->on('addresses')->nullOnDelete();
$table->foreign('default_shipping_address_id')->references('id')->on('addresses')->nullOnDelete();
if (!$this->isSqlite()) {
$table->foreign('default_billing_address_id')->references('id')->on('addresses')->nullOnDelete();
$table->foreign('default_shipping_address_id')->references('id')->on('addresses')->nullOnDelete();
}
});
}

Expand Down

0 comments on commit 18b94d3

Please sign in to comment.