Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ReactiveImagePicker] selectedValueBuilder can't take input of new files #157

Closed
UsamaKarim opened this issue Sep 7, 2024 · 12 comments
Closed

Comments

@UsamaKarim
Copy link
Contributor

selectedValueBuilder can handle both deletion and changing, but it lacks adding new files.

Fortunately, the fix is easy, internally the files are added through _handleChange(context, null) method. It means if the OnChange signature take null input, the files can be added easily

@alejandrogiubel
Copy link

waiting for this

@vasilich6107
Copy link
Contributor

vasilich6107 commented Oct 7, 2024

Hey @UsamaKarim @alejandrogiubel @qwezey
Could you give me more details

What you are trying to implement?

The selectedValueBuilder allows you to edit and delete selected image.
It also allows to replace the image with multiple images.(check the video)

I'm not sure that I understand your issue

Screen.Recording.2024-10-07.at.14.40.35.mov

@qwezey
Copy link

qwezey commented Oct 7, 2024

@vasilich6107 the issue here is lacking the ability to select more images (without replacing them) despite images already being selected

@UsamaKarim
Copy link
Contributor Author

UsamaKarim commented Oct 7, 2024

Hey @UsamaKarim @alejandrogiubel @qwezey Could you give me more details

What you are trying to implement?

The selectedValueBuilder allows you to edit and delete selected image. It also allows to replace the image with multiple images.(check the video)

I'm not sure that I understand your issue

Screen.Recording.2024-10-07.at.14.40.35.mov

Oh, onChange can add multiple files, I was supposed to just change that single file I tapped on. I think it seems confusing.

My suggestions.

  1. A user can add more (new) files that will not change any previous files but add them at the end of the list.
  2. A user can change file, (picker should not allow multiple files in this case)
  3. A user can delete file. (already implemented)

@vasilich6107
Copy link
Contributor

vasilich6107 commented Oct 7, 2024

@qwezey @UsamaKarim
Could you explain which UI you are trying to build?
Currently we are discussing just a raw features

selectedValueBuilder is about building and manipulating the selected image.
Probably not about adding more

@UsamaKarim
Copy link
Contributor Author

Screenshot 2024-10-07 at 6 37 56 PM

I hope this picture explains it.
Can I know other than selectedValueBuilder what should I use?

@vasilich6107
Copy link
Contributor

@UsamaKarim
thanks for clarification
Let me check

@vasilich6107
Copy link
Contributor

Hey @UsamaKarim could you clone the repo and run example inside ReactiveImagePicker to check if it works for you

@UsamaKarim
Copy link
Contributor Author

UsamaKarim commented Oct 7, 2024

Hey @UsamaKarim could you clone the repo and run example inside ReactiveImagePicker to check if it works for you

Sure, I'll let you know soon.

@UsamaKarim
Copy link
Contributor Author

Hey @UsamaKarim could you clone the repo and run example inside ReactiveImagePicker to check if it works for you

It's working great.

@vasilich6107
Copy link
Contributor

check reactive_image_picker 7.0.0

Copy link

github-actions bot commented Oct 8, 2024

Hi @UsamaKarim!
Your issue has been closed. If we were helpful don't forget to star the repo.

Please check our reactive_forms_generator package

We would appreciate sponsorship subscription or one time donation
https://github.com/sponsors/artflutter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants