Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect Time Handling on DST Transition Days #139

Closed
glebamichal opened this issue Feb 23, 2024 · 3 comments
Closed

Incorrect Time Handling on DST Transition Days #139

glebamichal opened this issue Feb 23, 2024 · 3 comments

Comments

@glebamichal
Copy link

Hello,

I've encountered a problem with the reactive date time picker package related to Daylight Saving Time (DST) adjustments. Specifically, when selecting a time on the days when DST changes (e.g., the start in March and the end in October), the time saved by the picker is automatically adjusted by one hour, which is incorrect for my use case.

Issue Description
Date and Time Selection: When I select a time on 30 March 2024, which is the DST start date for many regions (the clocks go forward), and choose 15:00, the time that gets saved and displayed in the application is 16:00. This automatic adjustment makes it impossible to save the correct time through the picker for this particular day.
Autumn Adjustment: A similar issue occurs on the DST end date in October, but in reverse; selecting a time results in the saved time being an hour earlier than what was selected.

Impact
This behavior disrupts functionality for any application feature relying on accurate time selection by users, especially for events or appointments scheduled on DST transition days.

Request for Solution or Advice
I am looking for a way to address or work around this issue. Ideally, the picker would not auto-adjust the selected time based on DST changes, or there would be a configuration option to disable this behaviour.

Your guidance on how to handle or fix this issue would be greatly appreciated.

Thank you for your support.

@vasilich6107
Copy link
Contributor

vasilich6107 commented Feb 23, 2024

Hi.
Does flutter native components have same behavior?
I do not apply any manual time adjustments in widget code.

@vasilich6107
Copy link
Contributor

vasilich6107 commented Aug 8, 2024

Hi @glebamichal
I've updated the internals of combine function, this should help to deal with DST transions
Could you check if reactive_date_time_picker 4.0.0 works for you.

Copy link

github-actions bot commented Oct 8, 2024

Hi @glebamichal!
Your issue has been closed. If we were helpful don't forget to star the repo.

Please check our reactive_forms_generator package

We would appreciate sponsorship subscription or one time donation
https://github.com/sponsors/artflutter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants