ToggleShieldsPacket vs ToggleRedAlertPacket #182
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JordanLongstaff
suggested changes
Nov 16, 2019
StarryWisdom
approved these changes
Nov 17, 2019
|
Re-pushed with signature for that |
Seems to be. Worked on my local copy much better than the live one anyway. |
Merged
|
Dropping in favour of #188 which not only fixes the duplicate |
NoseyNick
added a commit
that referenced
this pull request
Dec 2, 2019
Fix #187 - a big bunch of HTML fixes in order to get valid HTML / clean results from https://validator.w3.org/nu/?doc=https%3A%2F%2Fartemis-nerds.github.io%2Fprotocol-docs%2F Specifically: - `<content>` is apparently no longer a thing? Really? Converted to `<div>` - The above required a corresponding `script.js` fix too - `<a target="_new">` should apparently now be `<a target="_blank">` - Some `<ul>` moved outside `<p>` - Some `<dl> / <dt> / <dd>` structure fixed - Unfortunately **A LOT** of indentation fixed because of the above - see diffs without whitespace - This may cause merge conflicts with some of my other pending changes - will fix case-by-case - Apparently bad practice to change number of cols in a table? Added some empty `<td>` - Fixed the `toggleredalert` duplicate to the correct `toggleshields` - obsoletes #182 / fixes #181 - `alt` added to all `<img>` - rebased / resolved merge conflicts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Easy fix for #181 - mislabelled section