Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ToggleShieldsPacket link points to ToggleRedAlertPacket #181

Closed
aiden-w-135752345 opened this issue Nov 13, 2019 · 2 comments · Fixed by #188
Closed

ToggleShieldsPacket link points to ToggleRedAlertPacket #181

aiden-w-135752345 opened this issue Nov 13, 2019 · 2 comments · Fixed by #188
Assignees
@NoseyNick
Labels
ready for update

Comments

@aiden-w-135752345
Copy link

In the packet types table, clicking the link saying ToggleShieldsPacket shows the ToggleRedAlertPacket packet structure. Also, the section for ToggleShieldsPacket has the id for ToggleRedAlertPacket:
<section id="toggleredalertpacket">
@NoseyNick NoseyNick mentioned this issue Nov 16, 2019
Closed
@NoseyNick
Copy link
Collaborator

Thanks Aiden, easy fix in PR #182 will hopefully be reviewed / approved / merged soon.

@NoseyNick NoseyNick self-assigned this Nov 17, 2019
@NoseyNick NoseyNick mentioned this issue Nov 17, 2019
Merged
@NoseyNick
Copy link
Collaborator

Will be fixed by #188 , which is more comprehensive than #182 - now dropped.

NoseyNick added a commit that referenced this issue Dec 2, 2019
@NoseyNick
HTML fixes (#188)
3c476d9 
Fix  #187 - a big bunch of HTML fixes in order to get valid HTML / clean results from https://validator.w3.org/nu/?doc=https%3A%2F%2Fartemis-nerds.github.io%2Fprotocol-docs%2F 
Specifically:

- `<content>` is apparently no longer a thing? Really? Converted to `<div>`
- The above required a corresponding `script.js` fix too
- `<a target="_new">` should apparently now be `<a target="_blank">`
- Some `<ul>` moved outside `<p>`
- Some `<dl> / <dt> / <dd>` structure fixed
- Unfortunately **A LOT** of indentation fixed because of the above - see diffs without whitespace
- This may cause merge conflicts with some of my other pending changes - will fix case-by-case
- Apparently bad practice to change number of cols in a table? Added some empty `<td>`
- Fixed the `toggleredalert` duplicate to the correct `toggleshields` - obsoletes #182 / fixes #181 
- `alt` added to all `<img>`
- rebased / resolved merge conflicts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NoseyNick NoseyNick

Labels
ready for update
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

HTML fixes artemis-nerds/protocol-docs
2 participants
@NoseyNick @aiden-w-135752345