Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jam32/jamCRC and crc32 #178

Closed
StarryWisdom opened this issue Feb 8, 2019 · 1 comment
Closed

jam32/jamCRC and crc32 #178

StarryWisdom opened this issue Feb 8, 2019 · 1 comment
Assignees

Comments

@StarryWisdom
Copy link
Collaborator

I think it would be helpful to mention that the jamCRC hash is a bitwise not of the CRC32 hash
To this non java programmer knowing that is more helpful than the sample code .... which link to a dead link anyway
Unsure if it should be noted under ButtonClickPacket or Packet Structure

I guess a first draft of changes - under Packet Structure change
"This value is a JamCRC hash of the internal name of the packet type."
to something like
"This value is a bitwise not of a CRC32 hash (aka JamCRC) of the internal name of the packet type."
or
"This value is a JamCRC hash of the internal name of the packet type. JamCRC is a bitwise not of a CRC32 hash"

under ButtonClickPacket
either update and move the sample code link to the Packet Structure part of the doc and update the text "This is a hash of the button's label computed using the JamCRC hash algorithm." to either match as above or refer to above like "This is a hash of the button's label computed using the JamCRC hash algorithm. See Packet Structure for details on JamCRC"

NoseyNick added a commit that referenced this issue Nov 17, 2019
@NoseyNick NoseyNick self-assigned this Nov 17, 2019
rjwut added a commit that referenced this issue Dec 2, 2019
@NoseyNick
Copy link
Collaborator

Resolved by #183 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants