[Draft] Disabling threading #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, Dysco uses multi-threading and caching for compressing the data. Decompressing is serial.
This behaviour has caused problems when writing to measurement sets itself is also parallelized, for example by running many DP3 instances at the same time. At that point, this was solved by reducing the maximum nr of threads to 8 (instead of to the nr of CPU cores). Recently, @adrabent reported more issues when running aoflagger on a spw combined set. These issues, together with that I'm not sure how much the multi-threading really improves in common cases, gave rise to developing a branch in which threading is disabled.
This is quite a big change, and due to the implications to production data quality associated with Dysco, I'll keep this thread open for a while, for testing, before merging it.