Merge pull request #35 from armortal/34-update-rsa-publicexponent

fix(#34): use pointer
armortal · Apr 14, 2024 · c7b923a · c7b923a
2 parents 72ab19c + 3d1e9de
commit c7b923a
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 11 deletions.
diff --git a/README.md b/README.md
@@ -385,7 +385,7 @@ func main() {
 			Params: &rsa.HashedKeyGenParams{
 				KeyGenParams: rsa.KeyGenParams{
 					ModulusLength:  2048,
-					PublicExponent: *big.NewInt(65537),
+					PublicExponent: big.NewInt(65537),
 				},
 				Hash: "SHA-256",
 			},

diff --git a/algorithms/rsa/rsa.go b/algorithms/rsa/rsa.go
@@ -44,7 +44,7 @@ type KeyGenParams struct {
 	// The length, in bits, of the RSA modulus
 	ModulusLength uint64
 	// The RSA public exponent
-	PublicExponent big.Int
+	PublicExponent *big.Int
 }
 
 // HashedKeyGenParams is the model of the dictionary specificationn at

diff --git a/algorithms/rsa/rsa_oaep.go b/algorithms/rsa/rsa_oaep.go
@@ -235,7 +235,7 @@ func (a *oaepSubtleCrypto) generateKeyOaep(algorithm *HashedKeyGenParams, extrac
 	alg := &KeyAlgorithm{
 		name:           rsaOaep,
 		modulusLength:  algorithm.ModulusLength,
-		publicExponent: &algorithm.PublicExponent,
+		publicExponent: algorithm.PublicExponent,
 		HashedKeyAlgorithm: &HashedKeyAlgorithm{
 			Hash: algorithm.Hash,
 		},

diff --git a/algorithms/rsa/rsa_oaep_test.go b/algorithms/rsa/rsa_oaep_test.go
@@ -33,7 +33,7 @@ func TestEncryptDecrypt(t *testing.T) {
 		Params: &HashedKeyGenParams{
 			KeyGenParams: KeyGenParams{
 				ModulusLength:  2048,
-				PublicExponent: *big.NewInt(65537),
+				PublicExponent: big.NewInt(65537),
 			},
 			Hash: "SHA-256",
 		},
@@ -69,7 +69,7 @@ func TestOaep_ExportKey(t *testing.T) {
 		Params: &HashedKeyGenParams{
 			KeyGenParams: KeyGenParams{
 				ModulusLength:  2048,
-				PublicExponent: *big.NewInt(65537),
+				PublicExponent: big.NewInt(65537),
 			},
 			Hash: "SHA-256",
 		},
@@ -164,7 +164,7 @@ func TestOaep_GenerateKey(t *testing.T) {
 			Params: &HashedKeyGenParams{
 				KeyGenParams: KeyGenParams{
 					ModulusLength:  2048,
-					PublicExponent: *big.NewInt(65537),
+					PublicExponent: big.NewInt(65537),
 				},
 				Hash: "SHA-256",
 			},
@@ -219,7 +219,7 @@ func TestOaep_GenerateKey(t *testing.T) {
 			Params: &HashedKeyGenParams{
 				KeyGenParams: KeyGenParams{
 					ModulusLength:  2048,
-					PublicExponent: *big.NewInt(65536),
+					PublicExponent: big.NewInt(65536),
 				},
 				Hash: "SHA-256",
 			},
@@ -235,7 +235,7 @@ func TestOaep_GenerateKey(t *testing.T) {
 			Params: &HashedKeyGenParams{
 				KeyGenParams: KeyGenParams{
 					ModulusLength:  2048,
-					PublicExponent: *big.NewInt(65537),
+					PublicExponent: big.NewInt(65537),
 				},
 				Hash: "SHA-256",
 			},
@@ -251,7 +251,7 @@ func TestOaep_GenerateKey(t *testing.T) {
 			Params: &HashedKeyGenParams{
 				KeyGenParams: KeyGenParams{
 					ModulusLength:  2048,
-					PublicExponent: *big.NewInt(65537),
+					PublicExponent: big.NewInt(65537),
 				},
 				Hash: "SHA-256",
 			},
@@ -269,7 +269,7 @@ func TestOaep_ImportKey(t *testing.T) {
 		Params: &HashedKeyGenParams{
 			KeyGenParams: KeyGenParams{
 				ModulusLength:  2048,
-				PublicExponent: *big.NewInt(65537),
+				PublicExponent: big.NewInt(65537),
 			},
 			Hash: "SHA-256",
 		},

diff --git a/examples/rsaoaep/main.go b/examples/rsaoaep/main.go
@@ -16,7 +16,7 @@ func main() {
 			Params: &rsa.HashedKeyGenParams{
 				KeyGenParams: rsa.KeyGenParams{
 					ModulusLength:  2048,
-					PublicExponent: *big.NewInt(65537),
+					PublicExponent: big.NewInt(65537),
 				},
 				Hash: "SHA-256",
 			},