Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assistant api v2 #33

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Assistant api v2 #33

wants to merge 12 commits into from

Conversation

armilam
Copy link
Owner

@armilam armilam commented Jun 2, 2017

Update to use assistant API v2. This makes some breaking changes, so this will need to bump the version of the gem. Resolves #29.

This branch is ready to test.

@armilam
Copy link
Owner Author

armilam commented Jun 2, 2017

At the bottom of https://github.com/armilam/google-assistant-ruby/tree/assistant-api-v2#testing-your-assistant, gactions preview needs to be updated for the new version of the CLI. It now uses gactions test and needs different arguments.

@Squareys
Copy link

Squareys commented Mar 12, 2018

@armilam Thanks for building this gem!

The new arguments for test are:

gactions --verbose test --action_package=action.json --project <the-project-id>
# or without --verbose
gactions test --action_package=action.json --project <the-project-id>

The action.json didn't work for me, this is what I have now:

{
    "manifest": {
        "displayName": "My Watchlist",
        "invocationName": "my watch list"
    },
    "actions": [
        {
            "name": "MAIN",
            "fulfillment": {
                "conversationName": "my-watchlist"
            },
            "intent": {
                "name": "actions.intent.MAIN"
            }
        }
    ],
    "conversations": {
        "my-watchlist": {
            "name": "my-watchlist",
            "url": "<the-url-to-deployed-app>",
            "fulfillmentApiVersion": 2
        }
    }
}

Apart from that, this works pretty well for me!

Cheers, Jonathan.

PS: Is there by chance a utility that allows testing the controller which handles the google assistant request? Something that basically allows sending a text intent request for example:

test "add command" do
    text_intent "add something" # Sends json parameters like google_assistant
    assert_response :success
end

@armilam
Copy link
Owner Author

armilam commented Mar 23, 2018

@Squareys thank you!

As you can see, I haven't done any work on this gem in a little while. I do hope to pick it up again, but for now I don't have the time.

If you would like to contribute, I would love to have the help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants