Add radxa-cm5-rpi-cm4-io support #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…otup" This reverts commit d376ca6. It's reported that when using Radxa CM5 with RPI CM4 IO board, USB2.0 host ports don't work. By default RK3588 USB DRD DWC3_0 (usb@fc000000) is set in otg mode. In hardware, RK3588 TYPEC0_USB20_OTG_ID is pulled down to groud by a 2.2k resistor. It is needed to perform GCTL_CORE_SOFTRESET during bootup. Signed-off-by: Stephen Chen <stephen@radxa.com> (cherry picked from commit ec8a9ad) Signed-off-by: Joshua Riek <jjriek@verizon.net>
|
This reverted commit does fix some other issues. Won't it have other side effects? |
|
I've not seen any bad side affects of this commit, from my perspective this looks good to merge. |
Joshua-Riek
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add dts for cm5-rpi-cm4-io
revert a commit for usb 2.0 to work on radxa cm5
tested working on rk-6.1-rkr1
additionally, these commits should also be merged to 5.10.