Skip to content

fix regression leading to FTBFS introduced in #7910 #7956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

fix regression leading to FTBFS introduced in #7910 #7956

wants to merge 2 commits into from

Conversation

leggewie
Copy link
Collaborator

Description

#7910 is a step in the right direction but uses incorrect syntax or incorrect assumptions: git needs to be called from within $GITDIR. This leads to build failures .

git.sh currently fails because git is usually called from outside the
git directory it is supposed to work on.  Before ccde662ccbdea2b0a1089
git config was called with --global which was wrong (#7907) but worked
from any directory.  Now git config is called correctly with --local
but that only works when cd'ing into the git directory first.

I added an unrelated, small typo nitpick commit for good measure in this PR.

How Has This Been Tested?

Untested, but code inspection and studies of the relevant docs and testing with regards to the general working of git was done locally.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

leggewie added 2 commits March 16, 2025 21:16
@leggewie
lib: cd into $GITDIR before calling git (Fixes: armbian#7910)
8b01cc1 
git.sh currently fails because git is usually called from outside the
git directory it is supposed to work on.  Before ccde662
git config was called with --global which was wrong (armbian#7907) but worked
from any directory.  Now git config is called correctly with --local
but that only works when cd'ing into the git directory first.
@leggewie
nitpick: spell check s/neeeded/needed/
9f4c0dd
@leggewie leggewie requested a review from a team as a code owner March 16, 2025 13:24
@github-actions github-actions bot added size/small PR with less then 50 lines Needs review Seeking for review Framework Framework components labels Mar 16, 2025
@igorpecovnik
Copy link
Member

igorpecovnik commented Mar 16, 2025 •
edited
Loading

Untested

Don't work :( Same error. // wait

@igorpecovnik
Copy link
Member

Closing. Not a solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Framework Framework components Needs review Seeking for review size/small PR with less then 50 lines
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leggewie @igorpecovnik