Skip to content

Stop altering global git config file and set safe per cloned repository #7910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 16, 2025
Merged

Stop altering global git config file and set safe per cloned repository #7910

merged 1 commit into from
Mar 16, 2025

Conversation

igorpecovnik
Copy link
Member

@igorpecovnik igorpecovnik commented Mar 4, 2025 •
edited
Loading

Description

Replace ugly workaround with a proper solution. Now safe folder is added to each cloned repository.

Closing #7907 AR-2624

How Has This Been Tested?

  • Run compilation with and without Docker

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@igorpecovnik igorpecovnik requested a review from a team as a code owner March 4, 2025 10:36
@github-actions github-actions bot added size/small PR with less then 50 lines Needs review Seeking for review Framework Framework components labels Mar 4, 2025
@igorpecovnik igorpecovnik added Ready to merge Reviewed, tested and ready for merge 05 Milestone: Second quarter release and removed Needs review Seeking for review labels Mar 16, 2025
@igorpecovnik igorpecovnik merged commit ccde662 into main Mar 16, 2025
@igorpecovnik igorpecovnik deleted the gitsafe branch March 16, 2025 10:53
@leggewie
Copy link
Collaborator

https://github.com/armbian/os/actions/runs/13882805130/job/38843739701#step:8:998

I believe this commit results in build failures. Needs inspection.

leggewie added a commit to leggewie/armbian-build that referenced this pull request Mar 16, 2025
@leggewie
switch into git directory before calling git (Fixes: armbian#7910)
ac5e69a 
git currently fails because it is usually called from outside the git
directory it is supposed to work on.
leggewie added a commit to leggewie/armbian-build that referenced this pull request Mar 16, 2025
@leggewie
lib: cd before calling git (Fixes: armbian#7910)
ae1e6ec 
git currently fails because it is usually called from outside the git
directory it is supposed to work on.
leggewie added a commit to leggewie/armbian-build that referenced this pull request Mar 16, 2025
@leggewie
lib: cd into $GITDIR before calling git (Fixes: armbian#7910)
8b01cc1 
git.sh currently fails because git is usually called from outside the
git directory it is supposed to work on.  Before ccde662
git config was called with --global which was wrong (armbian#7907) but worked
from any directory.  Now git config is called correctly with --local
but that only works when cd'ing into the git directory first.
@leggewie
Copy link
Collaborator

https://github.com/armbian/os/actions/runs/13882805130/job/38843739701#step:8:998

I believe this commit results in build failures. Needs inspection.

I have prepared a PR

@leggewie leggewie mentioned this pull request Mar 16, 2025
Closed
2 tasks
@igorpecovnik igorpecovnik mentioned this pull request Mar 16, 2025
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
05 Milestone: Second quarter release Framework Framework components Ready to merge Reviewed, tested and ready for merge size/small PR with less then 50 lines
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@igorpecovnik @leggewie