Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix misleading generator message #231

Merged
merged 1 commit into from
Oct 16, 2024
Merged

fix misleading generator message #231

merged 1 commit into from
Oct 16, 2024

Conversation

rayandrew
Copy link
Contributor

@rayandrew rayandrew commented Oct 15, 2024 •
edited
Loading

Hi @zhenghh04 and @hariharan-devarajan,

The current message says Generating NPZ data when it should say Generating HDF5 data.
This can be misleading for users.

@rayandrew
fix misleading generator message
7bfd89d 
The message should be `Generating HDF5 data` instead of NPZ
hariharan-devarajan
hariharan-devarajan approved these changes Oct 16, 2024
View reviewed changes
Copy link
Collaborator

@hariharan-devarajan hariharan-devarajan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the catch

@zhenghh04 zhenghh04 merged commit 05d67d1 into argonne-lcf:main Oct 16, 2024
6 checks passed
@rayandrew rayandrew deleted the fix/hdf5-generator-info-msg branch October 16, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hariharan-devarajan hariharan-devarajan hariharan-devarajan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rayandrew @hariharan-devarajan @zhenghh04