fix: argent mobile connector based on in app browser #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluecco
requested review from
dmcrodrigues,
mluisbrown,
Inukares,
Cussone,
kamilargent and
vladutjs
and removed request for
mluisbrown
kamilargent
reviewed
Aug 7, 2024
src/connectors/argentMobile/index.ts
Outdated
| export class ArgentMobileConnector { | ||
| static init(options: ArgentMobileConnectorOptions = {}) { | ||
| if (isInArgentMobileAppBrowser()) { | ||
| return new InjectedConnector({ options: { id: "argentX" } }) |
There was a problem hiding this comment.
shouldn't we also configure name and icon in the options here?
There was a problem hiding this comment.
yeah, will add tomorrow
kamilargent
approved these changes
Aug 7, 2024
|
What is the issue that this is fixing? |
bluecco
commented
Aug 8, 2024
| @@ -1,6 +1,10 @@ | |||
| import type { StarknetWindowObject } from "@starknet-io/types-js" | |||
|
|
|||
| export const isInArgentMobileAppBrowser = (): boolean => { | |||
| if (typeof window === "undefined") { | |||
|
kamilargent
approved these changes
Aug 8, 2024
Cussone
approved these changes
Aug 8, 2024
vladutjs
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue / feature description
Many dapps don’t support in-app browser properly and add Mobile connector instead which makes for poor experience.
Changes
When the dapp would want to create mobile connector, we could check if it’s in app browser, and return the standard connector instead.
ArgentMobileBaseConnectorArgentMobileConnectornow provide a static method to instantiate the right connectorChecklist
Please keep your pull request as small as possible. If you need to make multiple changes, please create separate pull requests for each change. Create a draft pull request if you need early feedback. This will mark the pull request as a work in progress and prevent it from being reviewed or merged until you are ready.
Please move drafts to the ready for review (regular PR) when you are ready to start the review process and other developers will pick it up from there.