Update to SNIP12 version 1 #2
Conversation
scripts/v1/StructWithString.ts
Outdated
| } | ||
|
|
||
| function getTypedDataHash(myStruct: StructWithString, chainId: string, owner: bigint): string { | ||
| console.log(JSON.stringify(getTypedData(myStruct, chainId))); |
There was a problem hiding this comment.
Yeah, it is to be able to copy paste it as a CONST in the .cairo file, tbh I should prob print the escaped version 🤔
There was a problem hiding this comment.
Actually you were right.
Although the idea of printing the escaped version is handy, it is not straigtforward...
Removed them all :D
|
struct within struct is u256 and SNIP-12 doesn't support enum, but still maybe there should be an example indeed 🤔 |
|
Can someone double check about |
| use off_chain_signature::interfaces::{IOffChainMessageHash, IStructHash, v1::StarknetDomain}; | ||
|
|
||
| const STRUCT_WITH_U256_TYPE_HASH: felt252 = | ||
| selector!("\"StructWithString\"(\"some_felt252\":\"felt\",\"some_string\":\"string\")"); |
There was a problem hiding this comment.
i would user human readable names to encourage builders to use readable data to sign, For instance "Some String"
There was a problem hiding this comment.
Updated all V1 files, as this was not encouraged in V0 I left them as is.
Should I update V0 to use CamelCase naming in the interface for the ts files?
interface SimpleStruct {
some_felt252: string;
some_u128: string;
}
// Will become
interface SimpleStruct {
someFelt252: string;
someU128: string;
}?
There was a problem hiding this comment.
yeah, in the TS files i'd the js notation "someFelt252". maybe the actual name like "Some Felt 252" but no reason to use the snake_case
There was a problem hiding this comment.
Still smthng to be done? bit confused as you approved ^^'
There was a problem hiding this comment.
ah, no, looks like this was already done
No description provided.