removing todo

argentlabs · Nov 1, 2024 · e2372f7 · e2372f7
1 parent 9b7458c
commit e2372f7
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 5 deletions.
diff --git a/Scarb.toml b/Scarb.toml
@@ -21,6 +21,4 @@ StructWithMerkletreeV1 = "npx ts-node scripts/v1/StructWithMerkletree.ts"
 StructWithU256 = "npx ts-node scripts/v0/StructWithU256.ts"
 StructWithU256V1 = "npx ts-node scripts/v1/StructWithU256.ts"
 StructWithString = "npx ts-node scripts/v1/StructWithString.ts"
-format = "scarb fmt && npx prettier --write ."
-
-## TODO ADD ALL STANDARD INTERFACES
+format = "scarb fmt && npx prettier --write ."
diff --git a/scripts/v1/StructWithString.ts b/scripts/v1/StructWithString.ts
@@ -21,7 +21,7 @@ interface StructWithString {
 function getDomain(chainId: string): StarknetDomain {
   return {
     name: "dappName",
-    version: shortString.encodeShortString("1"),
+    version: "1",
     chainId,
     revision: TypedDataRevision.ACTIVE,
   };

diff --git a/src/interfaces.cairo b/src/interfaces.cairo
@@ -5,7 +5,6 @@ trait IOffChainMessageHash<T> {
     fn get_message_hash(self: @T) -> felt252;
 }
 
-
 /// @notice Defines the function to generates the SNIP-12
 trait IStructHash<T> {
     fn get_struct_hash(self: @T) -> felt252;