Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gba: add option to enable Game Boy Player #1856

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

png183
Copy link
Contributor

@png183 png183 commented Feb 22, 2025

Re-adds support for Game Boy Player rumble, with a UI toggle to enable/disable the feature.

@LukeUsher
Copy link
Member

Nice!

The reason this was changed initially was because the GBAVideo titles do not run under the Game Boy Player; but it is great to have it as an option.

Just a little thing: can we consider adding a 'deviceName' variable to the Emulator::GameBoyAdvance struct, so that rather than duplicated cases, we can just have

deviceName = settings.gameBoyAdvance.player ? "Game Boy Player" : "Game Boy Advance";

And then InputPort, GameBoyAdvance::load, and the pac lookup can just use this string instead, avoiding the duplication?

String concat in ares is easy: if(!ares::GameBoyAdvance::load(root, {"[Nintendo]", deviceName})) return otherError; should work, for example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants