Browser field outside block not saving to DB

[ruudbwai]

Hi there,

I'm really enjoying twill. Really close to getting it to behave as I'd like, but have an issue.

Another silly question, and feels like it's something simple I'm missing, so asking as a question. Feels like it's related to this - #45 , but I can't get my browser to save anything from outside blocks.

I'm trying to attach menu items to menus. Using a browser for the menu items.

I have created the pivot table, the relationship, and added the afterSave and getFormFields methods to the menu repository.

My menu form.blade.php has the browser field as below

    @formField('browser', [
        'label' => 'Menu items',
        'name' => 'menuItems',
        'moduleName' => 'menuItems'
    ])

My Menu model has the relationship to the menu items as below

public function menu_items()
    {
        return $this->belongsToMany(MenuItem::class, 'menus_to_menu_items', 'menu_id', 'menu_item_id')->withPivot('position')->orderBy('position');
    
    }

My pivot table menus_to_menu_items migration up method

public function up()
    {
        Schema::create('menus_to_menu_items', function (Blueprint $table) {
            $table->bigIncrements('id');
            $table->timestamps();
            $table->integer('position')->unsigned();
            createDefaultRelationshipTableFields($table, 'menu', 'menu_item');
        });
        
    }

My MenuRepository has the methods from the docs,

public function afterSave($object, $fields)
    {
        $this->updateBrowser($object, $fields, 'menu_items');
        parent::afterSave($object, $fields);
    }

    public function getFormFields($object)
    {
        $fields = parent::getFormFields($object);
        $fields['browsers']['menu_items'] = $this->getFormFieldsForBrowser($object, 'menu_items');
        return $fields;
    }

I can browse menu items, and select and can hit update.

I can actually see the payload from my network is as expected, but nothing is saved to my menus_to_menu_items table....

The response {"message":"Content saved. All good!","variant":"success"}

Question is, do I need to manually insert the record into the pivot table? The docs suggest this should happen automatically because of the $this->updateBrowser($object, $fields, 'menu_items'); line....but can't seem to get this to behave.

Or am I missing something really basic yet again?

Versions
Twill - 2.7.0
Laravel - 8.4.0
PHP - 7.4.16
DB - MariaDB 10.5.5

[ruudbwai]

Sorry, it was me being pepega as usual (naming things terribly).

I just followed the updateBrowser method in my MenuRepository and found it accepts a few more arguments

public function updateBrowser($object, $fields, $relationship, $positionAttribute = 'position', $browserName = null, $pivotAttributes = [])

So I gave it what it wanted according to my pepega naming

$this->updateBrowser($object, $fields, 'menu_items', 'position', 'menuItems');

And it now behaves, and records are saved as expected...In future I'll dig a little deeper before boring you all with silly questions. :D

p.s. hopefully it goes without saying, I also had to update the getFormFields method to correctly key in my menu items in browsers thus

$fields['browsers']['menuItems'] = $this->getFormFieldsForBrowser($object, 'menu_items');