minor fixes from PR feedback

ardeois · Feb 6, 2025 · 526f7c5 · 526f7c5
1 parent 4ceadba
commit 526f7c5
Showing 1 changed file with 3 additions and 7 deletions.
diff --git a/src/index.ts b/src/index.ts
@@ -742,7 +742,7 @@ export const plugin: PluginFunction<TypescriptMocksPluginConfig> = (schema, docu
                     const { directives } = node;
                     const hasOneOfDirective = directives.some((directive) => directive.name.value === 'oneOf');
 
-                    if (node.fields && hasOneOfDirective) {
+                    if (node.fields && node.fields.length > 0 && hasOneOfDirective) {
                         const field = node.fields[0];
                         const value = generateMockValue({
                             typeName: fieldName,
@@ -754,19 +754,15 @@ export const plugin: PluginFunction<TypescriptMocksPluginConfig> = (schema, docu
                         mockFieldsString = `        ...(override ? override : {${field.name.value} : ${value}}),`;
                     } else if (node.fields) {
                         mockFieldsString = node.fields
-                            .map((field, index) => {
+                            .map((field) => {
                                 const value = generateMockValue({
                                     typeName: fieldName,
                                     fieldName: field.name.value,
                                     currentType: field.type,
                                     ...sharedGenerateMockOpts,
                                 });
 
-                                const valueWithOverride = `overrides && overrides.hasOwnProperty('${
-                                    field.name.value
-                                }') ? overrides.${field.name.value}! : ${
-                                    !hasOneOfDirective || index === 0 ? value : 'undefined'
-                                }`;
+                                const valueWithOverride = `overrides && overrides.hasOwnProperty('${field.name.value}') ? overrides.${field.name.value}! : ${value}`;
 
                                 return `        ${field.name.value}: ${valueWithOverride},`;
                             })